kokonguyen191 commented on PR #6759: URL: https://github.com/apache/hadoop/pull/6759#issuecomment-2081512148
Hi @Hexiaoqiao, thanks for the review. For your first question, `getPerStorageIBR(storage)` doesn't do a null check on `storage` and assigns a new `PerStorageIBG` object to `null`. So it pretty much just considers `null` to be a new storage. For your second question, the NPE in IBRs is caused by a block report with `null` storage. The condition for this to happen is for a storage to be removed after `DirectoryScanner` has just finished a scan but hasn't started processing the blocks yet, so the scan result is now stale and contains removed storage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
