brumi1024 commented on code in PR #6770:
URL: https://github.com/apache/hadoop/pull/6770#discussion_r1583197107
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/ResourceHandlerModule.java:
##########
@@ -69,9 +70,9 @@ public class ResourceHandlerModule {
private static volatile CGroupsHandler cGroupsHandler;
private static volatile CGroupsBlkioResourceHandlerImpl
cGroupsBlkioResourceHandler;
- private static volatile CGroupsMemoryResourceHandlerImpl
+ private static volatile AbstractCGroupsMemoryResourceHandler
Review Comment:
Nit: there might not always be an abstract parent class for every
ResourceHandler, instead we could simply return the interface like some of the
getters already do.
AbstractCGroupsMemoryResourceHandler -> MemoryResourceHandler
AbstractCGroupsCpuResourceHandler -> CpuResourceHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
