virajjasani commented on PR #6543:
URL: https://github.com/apache/hadoop/pull/6543#issuecomment-2089805333
As of today, `fs.s3a.create.performance` is mandatory option while creating
file:
```
builder
.create()
.overwrite(true)
.must(FS_S3A_CREATE_PERFORMANCE, performanceCreation);
```
Shall we remove `fs.s3a.create.performance` as mandatory one and add
`fs.s3a.performance.options` instead? Can we add value of this config as
serialized string of `S3APerformanceFlags` object, and let `CreateFileBuilder`
deserialize it to `S3APerformanceFlags` object? This way, `CreateFileBuilder`
gets the object back, though this seems too complicated.
Instead, maybe we remove `fs.s3a.create.performance` as mandatory and
provide `S3APerformanceFlags` object (non-nullable) as part of
`CreateFileBuilder` constructor directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
