[
https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254863#comment-13254863
]
Hadoop QA commented on HADOOP-8172:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522820/HADOOP-8172-branch-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test
files.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1028 javac compiler warnings (more
than the trunk's current 1014 warnings).
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.conf.TestConfigurationDeprecation
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/857//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/857//console
This message is automatically generated.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response
> to a recent test failure. The patch appears to have changed the following
> code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the
> first one in the list will be set, where as previously all of them would be
> set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
