CloudZY commented on code in PR #6774:
URL: https://github.com/apache/hadoop/pull/6774#discussion_r1597249343
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java:
##########
@@ -601,18 +604,22 @@ public void run() {
NameNode.LOG.error("Cannot warm up EDEKs.", e);
throw e;
}
- try {
- Thread.sleep(retryInterval);
- } catch (InterruptedException ie) {
- NameNode.LOG.info("EDEKCacheLoader interrupted during retry.");
- break;
+
+ if (!success) {
+ try {
+ Thread.sleep(retryInterval);
+ } catch (InterruptedException ie) {
+ NameNode.LOG.info("EDEKCacheLoader interrupted during retry.");
+ break;
+ }
+ retryCount++;
}
- sinceLastLog += retryInterval;
Review Comment:
It does not get updated since initial settings. Shall we add it back or
remove its usages completely as Simba said?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
