Hexiaoqiao commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2106824252
@ChenSammi Got it. Make sense to me. > Yes, removing the synchronized directly have potential risks to sub classes of AbstractDelegationTokenSecretManager. Using LOCK is a safe way to replace synchronized and can improve the concurrency too. That's the motivation of this implementation. @vikaskr22 The current changes LGTM. One nit comment about `mvnsite` build failed, not sure if related with this changes. Would you mind to double check? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
