goiri commented on code in PR #6844:
URL: https://github.com/apache/hadoop/pull/6844#discussion_r1616463020
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterSafemodeService.java:
##########
@@ -174,7 +167,7 @@ public void periodicInvoke() {
// Always update to indicate our cache was updated
if (isCacheStale) {
if (!safeMode) {
- enter();
+ enter(false);
Review Comment:
Wouldn't make more sense to use `leave()`?
It would be good to have unified enter and leave, and just have a call to
each.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
