saxenapranav commented on code in PR #6752:
URL: https://github.com/apache/hadoop/pull/6752#discussion_r1617134507
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -223,6 +225,21 @@ public void initialize(URI uri, Configuration
configuration)
}
}
+ if ((abfsConfiguration.createEncryptionContextProvider() != null
+ || StringUtils.isNotEmpty(
+ abfsConfiguration.getEncodedClientProvidedEncryptionKey()))
+ && !getIsNamespaceEnabled(
+ new TracingContext(clientCorrelationId, fileSystemId,
+ FSOperationType.CREATE_FILESYSTEM, tracingHeaderFormat,
listener))) {
+ /*
+ * Close the filesystem gracefully before throwing exception. Graceful
close
+ * will ensure that all resources are released properly.
+ */
+ close();
Review Comment:
That should be fine, as the application would get the error. And, also, the
finalize() method would retrigger close(). Does it look good to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
