[ 
https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850907#comment-17850907
 ] 

ASF GitHub Bot commented on HADOOP-18516:
-----------------------------------------

anujmodi2021 opened a new pull request, #6855:
URL: https://github.com/apache/hadoop/pull/6855

   ### Description of PR
   Jira: https://issues.apache.org/jira/browse/HADOOP-18516
   Changes ported from PR: https://github.com/apache/hadoop/pull/5148
   
   This PR introduces a new configuration for Fixed SAS Tokens: 
**"fs.azure.sas.fixed.token"**
   
   Using this new configuration, users can configure a fixed SAS Token in the 
account settings files itself. Ideally, this should be used with SAS Tokens 
that are scoped at a container or account level (Service or Account SAS), which 
can be considered to be a constant for one account or container, over multiple 
operations.
   
   The other method of using a SAS Token remains valid as well, where a user 
provides a custom implementation of the SASTokenProvider interface, using which 
a SAS Token are obtained.
   
   When an Account SAS Token is configured as the fixed SAS Token, and it is 
used, it is ensured that operations are within the scope of the SAS Token. 
   
   The code checks for whether the fixed token and the token provider class 
implementation are configured. In the case of both being set, preference is 
given to the custom SASTokenProvider implementation. It must be noted that if 
such an implementation provides a SAS Token which has a lower scope than 
Account SAS, some filesystem and service level operations might be out of scope 
and may not succeed.
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> [ABFS]: Support fixed SAS token config in addition to Custom SASTokenProvider 
> Implementation
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-18516
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18516
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.4.0
>            Reporter: Sree Bhattacharyya
>            Assignee: Anuj Modi
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.5.0
>
>
> This PR introduces a new configuration for Fixed SAS Tokens: 
> *"fs.azure.sas.fixed.token"*
> Using this new configuration, users can configure a fixed SAS Token in the 
> account settings files itself. Ideally, this should be used with SAS Tokens 
> that are scoped at a container or account level (Service or Account SAS), 
> which can be considered to be a constant for one account or container, over 
> multiple operations.
> The other method of using a SAS Token remains valid as well, where a user 
> provides a custom implementation of the SASTokenProvider interface, using 
> which a SAS Token are obtained.
> When an Account SAS Token is configured as the fixed SAS Token, and it is 
> used, it is ensured that operations are within the scope of the SAS Token.
> The code checks for whether the fixed token and the token provider class 
> implementation are configured. In the case of both being set, preference is 
> given to the custom SASTokenProvider implementation. It must be noted that if 
> such an implementation provides a SAS Token which has a lower scope than 
> Account SAS, some filesystem and service level operations might be out of 
> scope and may not succeed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to