[
https://issues.apache.org/jira/browse/HADOOP-18603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851133#comment-17851133
]
ASF GitHub Bot commented on HADOOP-18603:
-----------------------------------------
simbadzina commented on code in PR #5581:
URL: https://github.com/apache/hadoop/pull/5581#discussion_r1622586601
##########
hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/LdapAuthenticationHandler.java:
##########
@@ -100,6 +100,12 @@ public class LdapAuthenticationHandler implements
AuthenticationHandler {
*/
public static final String ENABLE_START_TLS = TYPE + ".enablestarttls";
+ /**
+ * Constant for disabling the host name verification for this handler.
+ */
+ private static final String DISABLE_HOSTNAME_VERIFICATION = TYPE +
+ ".hostname.verification.disable";
Review Comment:
Could you please also add this new config in core-site default.
> NPE in LdapAuthenticationHandler as disableHostNameVerification is never
> initialized
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-18603
> URL: https://issues.apache.org/jira/browse/HADOOP-18603
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bilwa S T
> Assignee: Bilwa S T
> Priority: Major
> Labels: pull-request-available
>
> Steps to reproduce this issue:
> Enable ldap auth with tls by configuring these in core-site.xml
> 1. hadoop.http.authentication.multi-scheme-auth-handler.schemes = basic
> 2. hadoop.http.authentication.multi-scheme-auth-handler.schemes.basic.handler
> = ldap
> 3. hadoop.http.authentication.ldap.enablestarttls = true
>
> Trace:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.security.authentication.server.LdapAuthenticationHandler.authenticateWithTlsExtension(LdapAuthenticationHandler.java:261)
> at
> org.apache.hadoop.security.authentication.server.LdapAuthenticationHandler.authenticateUser(LdapAuthenticationHandler.java:238)
> at
> org.apache.hadoop.security.authentication.server.LdapAuthenticationHandler.authenticate(LdapAuthenticationHandler.java:202)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
