saxenapranav commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2162706178
> Overall, I like the design, especially the way that it is possible to switch back to the existing connections and in future move to the java11+ API. > > However, there is an absolute -1, KeepAliveCache contains code copied from the JDK. You get to delete all code which is duplicate and review it very carefully to make sure this is the case. > > I am not happy with us creating a long lived thread that never goes away. Yes, it is done for the JVM, but that's a long-standing design decision of theirs. Instead, make this one per abfs instance. When the filesystem is closed this cache can/should be shut down. Or is there something I am missing here -such as how it integrates with the JDK? > > As usual, I've complained about javadocs a lot. This is for the people that come to maintain it in the future, yourself included -and for IDE popups. Thank you @steveloughran for the review. Really appreciate your time in this. I have now differentiated KeepAliveCache code from the JDK's implementation. Now, each filesystem would have an instance of KeepAliveCache which maintains connection pooling for that filesystem. The cache would have a timer that would be running till the lifecycle of the filesystem. When filesystem is closed, the cache gets closed, and the timer also gets closed. I have taken the comments, requesting your kind review please. Thank you a lot again for your time and insights. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
