simbadzina commented on code in PR #6873:
URL: https://github.com/apache/hadoop/pull/6873#discussion_r1639044953
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestCombinedHostsFileReader.java:
##########
@@ -19,14 +19,23 @@
import java.io.File;
import java.io.FileWriter;
+import java.io.IOException;
+import java.util.concurrent.Callable;
import org.apache.hadoop.hdfs.protocol.DatanodeAdminProperties;
import org.apache.hadoop.test.GenericTestUtils;
import org.junit.Before;
+import org.junit.Rule;
Review Comment:
Unnecessary import.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestCombinedHostsFileReader.java:
##########
@@ -19,14 +19,23 @@
import java.io.File;
import java.io.FileWriter;
+import java.io.IOException;
+import java.util.concurrent.Callable;
import org.apache.hadoop.hdfs.protocol.DatanodeAdminProperties;
import org.apache.hadoop.test.GenericTestUtils;
import org.junit.Before;
+import org.junit.Rule;
import org.junit.After;
import org.junit.Test;
+import org.mockito.invocation.InvocationOnMock;
+import org.mockito.stubbing.Answer;
+import org.junit.rules.ExpectedException;
Review Comment:
Unnecessary import.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestCombinedHostsFileReader.java:
##########
@@ -44,8 +53,15 @@ public class TestCombinedHostsFileReader {
private final File legacyFile =
new File(TESTCACHEDATADIR, "legacy.dfs.hosts.json");
+ @Rule
+ public final ExpectedException exception = ExpectedException.none();
Review Comment:
This variable is not used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
