sodonnel commented on PR #6677:
URL: https://github.com/apache/hadoop/pull/6677#issuecomment-2167523722
@fateh288 there are still some checkstyle violations on lines that are
changed in this PR:
```
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:178:
protected boolean nonSuperUser = false; // enter/exit safe mode:23:
Variable 'nonSuperUser' must be private and have accessor methods.
[VisibilityModifier]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1044:
DatanodeStorage storage; //only one storage:21: Variable 'storage' must be
private and have accessor methods. [VisibilityModifier]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1177:
private int transferBlocks( Block blocks[],:31: '(' is followed by
whitespace. [ParenPad]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1177:
private int transferBlocks( Block blocks[],:39: 'blocks' hides a field.
[HiddenField]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1177:
private int transferBlocks( Block blocks[],:45: Array brackets at illegal
position. [ArrayTypeStyle]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1298:
LOG.error("Potentially insufficient permission: try running the tool
with -nonSuperUser argument or login as super user");: Line is longer than 100
characters (found 132). [LineLength]
```
If you could address these, we are good to commit this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
