[
https://issues.apache.org/jira/browse/HADOOP-19203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855734#comment-17855734
]
ASF GitHub Bot commented on HADOOP-19203:
-----------------------------------------
mukund-thakur commented on code in PR #6885:
URL: https://github.com/apache/hadoop/pull/6885#discussion_r1643437675
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FunctionalIO.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util.functional;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.util.function.Supplier;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+
+/**
+ * Functional utilities for IO operations.
+ */
[email protected]
+public final class FunctionalIO {
+
+ private FunctionalIO() {
+ }
+
+ /**
+ * Invoke any operation, wrapping IOExceptions with
+ * {@code UncheckedIOException}.
+ * @param call callable
+ * @param <T> type of result
+ * @return result
+ * @throws UncheckedIOException if an IOE was raised.
+ */
+ public static <T> T uncheckIOExceptions(CallableRaisingIOE<T> call) {
+ try {
+ return call.apply();
+ } catch (IOException e) {
+ throw new UncheckedIOException(e);
+ }
+ }
+
+ /**
+ * Wrap a {@link CallableRaisingIOE} as a {@link Supplier}.
+ * This is similar to {@link CommonCallableSupplier}, except that
+ * only IOExceptions are caught and wrapped; all other exceptions are
+ * propagated unchanged.
+ * @param <T> type of result
+ */
+ private static final class UncheckedIOExceptionSupplier<T> implements
Supplier<T> {
Review Comment:
I don't see any use of this so for though. Assuming it will be used later?
> WrappedIO BulkDelete API to raise IOEs as UncheckedIOExceptions
> ---------------------------------------------------------------
>
> Key: HADOOP-19203
> URL: https://issues.apache.org/jira/browse/HADOOP-19203
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.4.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> It's easier to invoke methods through reflection through parquet/iceberg
> DynMethods if the invoked method raises unchecked exceptions, because it
> doesn't then rewrape the raised exception in a generic RuntimeException
> Catching the IOEs and wrapping as UncheckedIOEs makes it much easier to
> unwrap IOEs after the invocation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
