[
https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859600#comment-17859600
]
ASF GitHub Bot commented on HADOOP-18679:
-----------------------------------------
alkis commented on code in PR #6726:
URL: https://github.com/apache/hadoop/pull/6726#discussion_r1650504558
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BulkDelete.java:
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+import org.apache.hadoop.fs.statistics.IOStatisticsSource;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * API for bulk deletion of objects/files,
+ * <i>but not directories</i>.
+ * After use, call {@code close()} to release any resources and
+ * to guarantee store IOStatistics are updated.
+ * <p>
+ * Callers MUST have no expectation that parent directories will exist after
the
+ * operation completes; if an object store needs to explicitly look for and
create
+ * directory markers, that step will be omitted.
+ * <p>
+ * Be aware that on some stores (AWS S3) each object listed in a bulk delete
counts
+ * against the write IOPS limit; large page sizes are counterproductive here,
as
+ * are attempts at parallel submissions across multiple threads.
+ * @see <a
href="https://issues.apache.org/jira/browse/HADOOP-16823";>HADOOP-16823.
+ * Large DeleteObject requests are their own Thundering Herd</a>
+ */
[email protected]
[email protected]
+public interface BulkDelete extends IOStatisticsSource, Closeable {
+
+ /**
+ * The maximum number of objects/files to delete in a single request.
+ * @return a number greater than zero.
+ */
+ int pageSize();
+
+ /**
+ * Base path of a bulk delete operation.
+ * All paths submitted in {@link #bulkDelete(Collection)} must be under this
path.
+ * @return base path of a bulk delete operation.
+ */
+ Path basePath();
+
+ /**
+ * Delete a list of files/objects.
+ * <ul>
+ * <li>Files must be under the path provided in {@link #basePath()}.</li>
+ * <li>The size of the list must be equal to or less than the page size
+ * declared in {@link #pageSize()}.</li>
+ * <li>Directories are not supported; the outcome of attempting to delete
+ * directories is undefined (ignored; undetected, listed as
failures...).</li>
+ * <li>The operation is not atomic.</li>
+ * <li>The operation is treated as idempotent: network failures may
+ * trigger resubmission of the request -any new objects created under
a
+ * path in the list may then be deleted.</li>
Review Comment:
It is great that we call this out, but can we do better at the API level?
Had the API took `Collection<FileStatus>`, we could make the operation
idempotent in most clouds by passing the version/generationid/etag in the
request.
> Add API for bulk/paged delete of files and objects
> --------------------------------------------------
>
> Key: HADOOP-18679
> URL: https://issues.apache.org/jira/browse/HADOOP-18679
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.5
> Reporter: Steve Loughran
> Assignee: Mukund Thakur
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.1
>
>
> iceberg and hbase could benefit from being able to give a list of individual
> files to delete -files which may be scattered round the bucket for better
> read peformance.
> Add some new optional interface for an object store which allows a caller to
> submit a list of paths to files to delete, where
> the expectation is
> * if a path is a file: delete
> * if a path is a dir, outcome undefined
> For s3 that'd let us build these into DeleteRequest objects, and submit,
> without any probes first.
> {quote}Cherrypicking
> {quote}
> when cherrypicking, you must include
> * followup commit #6854
> * https://issues.apache.org/jira/browse/HADOOP-19196
> * test fixes HADOOP-19814 and HADOOP-19188
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
