rakeshadr commented on code in PR #6893:
URL: https://github.com/apache/hadoop/pull/6893#discussion_r1667733260
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -395,14 +395,18 @@ private synchronized boolean
getNamespaceEnabledInformationFromServer(
try {
LOG.debug("Get root ACL status");
getClient().getAclStatus(AbfsHttpConstants.ROOT_PATH, tracingContext);
+ // If getAcl succeeds, namespace is enabled.
isNamespaceEnabled = Trilean.getTrilean(true);
} catch (AbfsRestOperationException ex) {
- // Get ACL status is a HEAD request, its response doesn't contain
- // errorCode
- // So can only rely on its status code to determine its account type.
+ // Get ACL status is a HEAD request, its response doesn't contain
errorCode
+ // So can only rely on its status code to determine account type.
if (HttpURLConnection.HTTP_BAD_REQUEST != ex.getStatusCode()) {
+ // If getAcl fails with anything other than 400, namespace is enabled.
+ isNamespaceEnabled = Trilean.getTrilean(true);
Review Comment:
Can you also add a debug log message to better understand the fallback cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
