[
https://issues.apache.org/jira/browse/HADOOP-18562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863870#comment-17863870
]
ASF GitHub Bot commented on HADOOP-18562:
-----------------------------------------
steveloughran commented on code in PR #6550:
URL: https://github.com/apache/hadoop/pull/6550#discussion_r1669005552
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java:
##########
@@ -775,6 +775,29 @@ private Constants() {
"fs.s3a." + Constants.AWS_SERVICE_IDENTIFIER_STS.toLowerCase()
+ ".signing-algorithm";
+ /** Prefix for S3A client-specific properties. */
Review Comment:
can you add an {@value} tag for this and the strings below, for better IDE
experience
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSClientConfig.java:
##########
@@ -407,6 +414,36 @@ private static void initSigner(Configuration conf,
}
}
+ /**
+ *
Review Comment:
need a title here
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java:
##########
@@ -775,6 +775,29 @@ private Constants() {
"fs.s3a." + Constants.AWS_SERVICE_IDENTIFIER_STS.toLowerCase()
+ ".signing-algorithm";
+ /** Prefix for S3A client-specific properties. */
+ public static final String FS_S3A_CLIENT_PREFIX = "fs.s3a.client.";
+
+ /** Custom headers postfix. */
+ public static final String CUSTOM_HEADERS_POSTFIX = ".custom.headers";
+
+ /**
+ * List of custom headers to be set on the service client.
+ * Multiple parameters can be used to specify custom headers.
+ * fs.s3a.client.s3.custom.headers - headers to add on all the s3 requests.
+ * fs.s3a.client.sts.custom.headers - headers to add on all the sts requests.
+ * Examples
+ * CustomHeader {@literal ->} 'Header1:Value1'
+ * CustomHeaders {@literal ->} 'Header1=Value1:Value2,Header2=Value1'
+ */
+ public static final String CUSTOM_HEADERS_STS =
+ FS_S3A_CLIENT_PREFIX + Constants.AWS_SERVICE_IDENTIFIER_STS.toLowerCase()
Review Comment:
1. no `Constants` reference needed here or below
2. Use `toLowerCase(Locale. ROOT)` unless you want to field support calls
from unusual locales
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSClientConfig.java:
##########
@@ -407,6 +414,36 @@ private static void initSigner(Configuration conf,
}
}
+ /**
+ *
+ * @param conf hadoop configuration
+ * @param clientConfig client configuration to update
+ * @param awsServiceIdentifier service name
+ */
+ private static void initRequestHeaders(Configuration conf,
+ ClientOverrideConfiguration.Builder clientConfig, String
awsServiceIdentifier) {
+ String configKey = null;
+ switch (awsServiceIdentifier) {
+ case AWS_SERVICE_IDENTIFIER_S3:
+ configKey = CUSTOM_HEADERS_S3;
+ break;
+ case AWS_SERVICE_IDENTIFIER_STS:
+ configKey = CUSTOM_HEADERS_STS;
+ break;
+ default:
+ // Nothing to do. The original signer override is already setup
Review Comment:
comment is wrong. just say "no known service"
> New configuration for static headers to be added to all S3 requests
> -------------------------------------------------------------------
>
> Key: HADOOP-18562
> URL: https://issues.apache.org/jira/browse/HADOOP-18562
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Daniel Carl Jones
> Priority: Minor
> Labels: pull-request-available
>
> Some users have the use case where for a particular S3A filesystem, they
> would like to set one or more headers to a static value.
> We might imagine a set of configurations properties with a common prefix,
> where the suffix determines the header name and the value of the property
> determines the value of the header.
> Per-filesystem headers can be set using the per-bucket configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
