slfan1989 commented on PR #6937: URL: https://github.com/apache/hadoop/pull/6937#issuecomment-2221670104
> I like the -1 here. emphasises that tests are not an option and that leaving out tests is a special case which needs active intervention +1 I agree with Steve's opinion that we expect unit tests to be added when submitting code. However, for tasks like upgrading jar dependencies or changing shell scripts, it should be confirmed by the reviewer whether unit tests are necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
