[ 
https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865848#comment-17865848
 ] 

ASF GitHub Bot commented on HADOOP-19120:
-----------------------------------------

saxenapranav commented on PR #6633:
URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2227641085

   ------------------------------
   :::: AGGREGATED TEST RESULT ::::
   
   ============================================================
   HNS-OAuth
   ============================================================
   
   [WARNING] Tests run: 154, Failures: 0, Errors: 0, Skipped: 3
   [WARNING] Tests run: 646, Failures: 0, Errors: 0, Skipped: 85
   [WARNING] Tests run: 424, Failures: 0, Errors: 0, Skipped: 57
   
   ============================================================
   HNS-SharedKey
   ============================================================
   
   [WARNING] Tests run: 154, Failures: 0, Errors: 0, Skipped: 4
   [WARNING] Tests run: 646, Failures: 0, Errors: 0, Skipped: 37
   [WARNING] Tests run: 424, Failures: 0, Errors: 0, Skipped: 44
   
   ============================================================
   NonHNS-SharedKey
   ============================================================
   [ERROR] 
testUpdateDeepDirectoryStructureToRemote(org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractDistCp)
  Time elapsed: 2.858 s  <<< FAILURE!
   
   [WARNING] Tests run: 154, Failures: 0, Errors: 0, Skipped: 10
   [WARNING] Tests run: 630, Failures: 0, Errors: 0, Skipped: 277
   [ERROR] Tests run: 424, Failures: 1, Errors: 0, Skipped: 47
   
   ============================================================
   AppendBlob-HNS-OAuth
   ============================================================
   
   [WARNING] Tests run: 154, Failures: 0, Errors: 0, Skipped: 3
   [WARNING] Tests run: 646, Failures: 0, Errors: 0, Skipped: 87
   [WARNING] Tests run: 424, Failures: 0, Errors: 0, Skipped: 81
   
   Time taken: 26 mins 22 secs.
   
   azureuser@pranav-ind-vm:~/hadoop/hadoop-tools/hadoop-azure$ git log
   commit f896d84d25a7991b21a5f835a468ff2afae649fd 
(origin/saxenapranav/abfs-apachehttpclient)
   Author: Pranav Saxena <>
   Date:   Thu Jul 11 06:48:53 2024 -0700
   
       eol fix
   
   




> [ABFS]: ApacheHttpClient adaptation as network library
> ------------------------------------------------------
>
>                 Key: HADOOP-19120
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19120
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.5.0
>            Reporter: Pranav Saxena
>            Assignee: Pranav Saxena
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.0, 3.4.1
>
>
> Apache HttpClient is more feature-rich and flexible and gives application 
> more granular control over networking parameter.
> ABFS currently relies on the JDK-net library. This library is managed by 
> OpenJDK and has no performance problem. However, it limits the application's 
> control over networking, and there are very few APIs and hooks exposed that 
> the application can use to get metrics, choose which and when a connection 
> should be reused. ApacheHttpClient will give important hooks to fetch 
> important metrics and control networking parameters.
> A custom implementation of connection-pool is used. The implementation is 
> adapted from the JDK8 connection pooling. Reasons for doing it:
> 1. PoolingHttpClientConnectionManager heuristic caches all the reusable 
> connections it has created. JDK's implementation only caches limited number 
> of connections. The limit is given by JVM system property 
> "http.maxConnections". If there is no system-property, it defaults to 5. 
> Connection-establishment latency increased with all the connections were 
> cached. Hence, adapting the pooling heuristic of JDK netlib,
> 2. In PoolingHttpClientConnectionManager, it expects the application to 
> provide `setMaxPerRoute` and `setMaxTotal`, which the implementation uses as 
> the total number of connections it can create. For application using ABFS, it 
> is not feasible to provide a value in the initialisation of the 
> connectionManager. JDK's implementation has no cap on the number of 
> connections it can have opened on a moment. Hence, adapting the pooling 
> heuristic of JDK netlib,



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to