raphaelazzolini commented on code in PR #6874:
URL: https://github.com/apache/hadoop/pull/6874#discussion_r1680279024
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/delegation/TestS3ADelegationTokenSupport.java:
##########
@@ -76,7 +76,7 @@ public void testSessionTokenDecode() throws Throwable {
renewer,
new URI("s3a://anything/"),
new MarshalledCredentials("a", "b", ""),
- new EncryptionSecrets(S3AEncryptionMethods.SSE_S3, ""),
+ new EncryptionSecrets(S3AEncryptionMethods.SSE_S3, "", ""),
Review Comment:
Not sure if this is was you meant, but in the next revision I will add
values to the key and encryption context instead of empty string. Then I will
assert that they match the valyes in the decoded identifier.
I will do the same in `testSessionTokenIdentifierRoundTrip()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
