shameersss1 commented on code in PR #6938:
URL: https://github.com/apache/hadoop/pull/6938#discussion_r1690800271
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java:
##########
@@ -228,15 +228,15 @@ protected Map<Class<? extends Exception>, RetryPolicy>
createExceptionMap() {
// throttled requests are can be retried, always
policyMap.put(AWSServiceThrottledException.class, throttlePolicy);
- // Status 5xx error code is an immediate failure
+ // Status 5xx error code has historically been treated as an immediate
failure
// this is sign of a server-side problem, and while
// rare in AWS S3, it does happen on third party stores.
// (out of disk space, etc).
// by the time we get here, the aws sdk will have
- // already retried.
+ // already retried, if it is configured to retry exceptions.
// there is specific handling for some 5XX codes (501, 503);
// this is for everything else
- policyMap.put(AWSStatus500Exception.class, fail);
+ policyMap.put(AWSStatus500Exception.class, retryAwsClientExceptions);
Review Comment:
Do we need to selectively retry 500 exception? Say only when the cause is
"Your socket connection......."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
