[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261145#comment-13261145 ]
Aaron T. Myers commented on HADOOP-8314: ---------------------------------------- Patch looks pretty good to me, Tucu. One small comment. This should either say either "users are not authorized" or "users are unauthorized" but _not_ "users are not unauthorized". :) {code} + response.sendError(HttpServletResponse.SC_UNAUTHORIZED, + "Unauthenticated users are not " + + "unauthorized to access this page."); {code} Otherwise the patch looks good. +1 pending Jenkins. > HttpServer#hasAdminAccess should return false if authorization is enabled but > user is not authenticated > ------------------------------------------------------------------------------------------------------- > > Key: HADOOP-8314 > URL: https://issues.apache.org/jira/browse/HADOOP-8314 > Project: Hadoop Common > Issue Type: Bug > Components: security > Affects Versions: 2.0.0, 3.0.0 > Reporter: Alejandro Abdelnur > Assignee: Alejandro Abdelnur > Fix For: 2.0.0 > > Attachments: HADOOP-8314.patch > > > If the user is not authenticated (request.getRemoteUser() returns NULL) or > there is not authentication filter configured (thus returning also NULL), > hasAdminAccess should return false. Note that a filter could allow anonymous > access, thus the first case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira