[
https://issues.apache.org/jira/browse/HADOOP-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869595#comment-17869595
]
ASF GitHub Bot commented on HADOOP-19187:
-----------------------------------------
anujmodi2021 commented on code in PR #6879:
URL: https://github.com/apache/hadoop/pull/6879#discussion_r1696681697
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -1400,6 +1418,29 @@ private FileStatus tryGetFileStatus(final Path f,
TracingContext tracingContext)
}
}
+ private boolean tryGetIsNamespaceEnabled(TracingContext tracingContext)
+ throws AzureBlobFileSystemException{
+ try {
+ return getIsNamespaceEnabled(tracingContext);
+ } catch (AbfsRestOperationException ex) {
+ /*
+ * Exception will be thrown for any non 400 error code.
+ * If status code is in 4xx range, it means it's an HNS account.
+ * If status code is in 5xx range, it means nothing can be inferred.
+ * In case of network errors status code will be -1.
+ */
+ int statusCode = ex.getStatusCode();
+ if (statusCode > HTTP_BAD_REQUEST && statusCode < HTTP_INTERNAL_ERROR) {
+ LOG.debug("getNamespace failed with non 400 user error", ex);
+ statIncrement(ERROR_IGNORED);
+ return true;
+ }
+ throw ex;
+ } catch (AzureBlobFileSystemException ex) {
Review Comment:
Makes sense, removed the catch block
> ABFS: [FnsOverBlob]Making AbfsClient Abstract for supporting both DFS and
> Blob Endpoint
> ---------------------------------------------------------------------------------------
>
> Key: HADOOP-19187
> URL: https://issues.apache.org/jira/browse/HADOOP-19187
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> Azure Services support two different set of APIs.
> Blob:
> [https://learn.microsoft.com/en-us/rest/api/storageservices/blob-service-rest-api]
>
> DFS:
> [https://learn.microsoft.com/en-us/rest/api/storageservices/datalakestoragegen2/operation-groups]
>
> As per the plan in HADOOP-19179, this task enables ABFS Driver to work with
> both set of APIs as per the requirement.
> Scope of this task is to refactor the ABfsClient so that ABFSStore can choose
> to interact with the client it wants based on the endpoint configured by user.
> The blob endpoint support will remain "Unsupported" until the whole code is
> checked-in and well tested.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
