[ 
https://issues.apache.org/jira/browse/HADOOP-19245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870456#comment-17870456
 ] 

ASF GitHub Bot commented on HADOOP-19245:
-----------------------------------------

steveloughran opened a new pull request, #6974:
URL: https://github.com/apache/hadoop/pull/6974

   
   ### Description of PR
   
   change signature of bridging class ProgressableListener so progress gets 
invoked
   as events happen during upload
   
   ### How was this patch tested?
   
   updated test; verified it failed before the production code change
   
   s3 london
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [X] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> S3ABlockOutputStream no longer sends progress events in close()
> ---------------------------------------------------------------
>
>                 Key: HADOOP-19245
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19245
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Critical
>
> We don't get progress events passed through from S3ABlockOutputStream to any 
> Progress instance passed in which doesn't implement ProgressListener
> This is due to a signature mismatch between the changed ProgressableListener 
> interface and the {{S3ABlockOutputStream.ProgressListener}} impl.
> * critical because distcp jobs will timeout on large uploads without this
> * trivial to fix; does need a test



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to