[
https://issues.apache.org/jira/browse/HADOOP-19248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870526#comment-17870526
]
ASF GitHub Bot commented on HADOOP-19248:
-----------------------------------------
pan3793 opened a new pull request, #6975:
URL: https://github.com/apache/hadoop/pull/6975
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
As part of HADOOP-16596, it switched from the vanilla protobuf to the shaded
one, thus the generated code by `protobuf` should be modified (replace package
name) before compiling and generating Javadoc.
Currently, the protobuf code generate happens in `generate-sources`(and
other similar phases), while the replace happens in `process-sources`, this is
OK for compiling but has problems for Javadoc.
```
$ mvn clean install -DskipTests
$ mvn javadoc:javadoc
```
The above commands won't trigger replace, thus the final generated Javadoc
refers to vanilla protobuf.
<img width="1428" alt="image"
src="https://github.com/user-attachments/assets/58dd666e-4c91-497c-ba7e-ffa272393378";>
The `javadoc`(Java 8) also complains that
```
[INFO] -
> Protobuf code generate and replace should happen together
> ---------------------------------------------------------
>
> Key: HADOOP-19248
> URL: https://issues.apache.org/jira/browse/HADOOP-19248
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Reporter: Cheng Pan
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
