[ 
https://issues.apache.org/jira/browse/HADOOP-16928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870542#comment-17870542
 ] 

ASF GitHub Bot commented on HADOOP-16928:
-----------------------------------------

pan3793 opened a new pull request, #6976:
URL: https://github.com/apache/hadoop/pull/6976

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   HADOOP-15902 added `-html4` options for javadoc on Java 11 and above, while 
`javadoc -html4` option has been removed since Java 13 
(https://bugs.openjdk.java.net/browse/JDK-8215578), and removed in recent Java 
versions.
   
   To make the javadoc work on Java 17, I must remove the `-html4` and fix all 
errors for `-html5`(this is default is the only option for Java 17 `javadoc`)
   
   ### How was this patch tested?
   
   macOS Java 17, aarch64
   
   ```
   $ java -version
   openjdk version "17.0.8" 2023-07-18 LTS
   OpenJDK Runtime Environment Zulu17.44+15-CA (build 17.0.8+7-LTS)
   OpenJDK 64-Bit Server VM Zulu17.44+15-CA (build 17.0.8+7-LTS, mixed mode, 
sharing)
   ```
   
   this works
   ```
   $ mvn package -Pdocs -DskipTests
   ```
   
   this also works
   ```
   $ mvn clean install -DskipTests
   $ mvn javadoc:javadoc
   ```
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> [JDK13] Support HTML5 Javadoc
> -----------------------------
>
>                 Key: HADOOP-16928
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16928
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Akira Ajisaka
>            Priority: Major
>
> javadoc -html4 option has been removed since Java 13.
> https://bugs.openjdk.java.net/browse/JDK-8215578



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to