KeeProMise commented on code in PR #6888:
URL: https://github.com/apache/hadoop/pull/6888#discussion_r1702062059
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -110,7 +110,46 @@ protected Boolean initialValue() {
@Unstable
public static <T extends Writable> AsyncGet<T, IOException>
getAsyncRpcResponse() {
- return (AsyncGet<T, IOException>) ASYNC_RPC_RESPONSE.get();
+ CompletableFuture<Writable> responseFuture = ASYNC_RPC_RESPONSE.get();
Review Comment:
> org.apache.hadoop.util.functional.FutureIO should have what you need here
already, with `raiseInnerCause` designed to expand that excution exception in a
lot more detail.
>
> * I'd propose a followup to switch to it
> * and if there is something missing which is broadl useful: add it
@steveloughran Thank you for your suggestion. FutureIO is indeed a good
util. we can consider using this util to improve this area in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
