zhengchenyu commented on PR #6964: URL: https://github.com/apache/hadoop/pull/6964#issuecomment-2272574201
@tomscut @zhangshuyan0 @haiyang1987 I think the problem is that ec's code is too dependent on the original process, the original process is based on continuous block copy. Many bugs come from over-reliance on this process and unnecessary parameter passing. I submit [HDFS-17542](https://github.com/apache/hadoop/pull/6915), try to rearrange these code. After this pr, I think there are no need to check the length of target. Can you please review HDFS-17542? As for the maintenance, maybe I think it is not just maintainance. There are some imperfections in calculating the ec replica state, mainly because the uniqueness of the internal blocks is not taken into account when calculating NumberReplicas. Although some issues attempt to solve these problems (such as the inaccurate calculation of DECOMMISSIONING solved by HDFS-14920), it is not thorough. [HDFS-17542](https://github.com/apache/hadoop/pull/6915) introduce NumberReplicasStriped, I think it is a better way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
