steveloughran commented on code in PR #6977:
URL: https://github.com/apache/hadoop/pull/6977#discussion_r1707069837
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceScheduler.java:
##########
@@ -1043,9 +1041,7 @@ private boolean terminateServiceIfAllComponentsFinished()
{
if (shouldTerminate) {
LOG.info("All component finished, exiting Service Master... "
- + ", final status=" + (failedComponents.isEmpty() ?
- "Succeeded" :
- "Failed"));
+ + ", final status={}", (failedComponents.isEmpty() ? "Succeeded" :
"Failed"));
Review Comment:
I'd prefer the ? : clause on its own line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
