pjfanning commented on code in PR #6953:
URL: https://github.com/apache/hadoop/pull/6953#discussion_r1715907737
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/main/java/org/apache/hadoop/yarn/appcatalog/application/YarnServiceClient.java:
##########
@@ -46,6 +47,19 @@
public class YarnServiceClient {
private static final Logger LOG =
LoggerFactory.getLogger(YarnServiceClient.class);
+
+ /**
+ * It is more performant to reuse ObjectMapper instances but keeping the
instance
Review Comment:
I am a committer on the Jackson project. There is minimal synchronisation
and I am actively removing many of the remaining cases. Even today, it is more
performant to reuse ObjectMapper instead of creating multiple instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]