shameersss1 commented on code in PR #6990:
URL: https://github.com/apache/hadoop/pull/6990#discussion_r1722840675
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java:
##########
@@ -658,6 +766,14 @@ private void
recoverResourceRequestForContainer(RMContainer rmContainer) {
return;
}
+ // when auto correct container allocation is enabled, there can be a case
when extra containers
+ // go to expired state from allocated state. When such scenario happens do
not re-attempt the
+ // container request since this is expected.
+ if (autoCorrectContainerAllocation &&
+ RMContainerState.EXPIRED.equals(rmContainer.getState())) {
+ return;
+ }
Review Comment:
Does preemption cause state of the container to be EXPIRED ? AFIK, The
EXPIRED state indicates the allocated container is not used within a specific
period.
Even if that is the case, The client would then request for additional
containers if its request is not satisfied instead of YARN proactively adding
the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
