[ 
https://issues.apache.org/jira/browse/HADOOP-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263198#comment-13263198
 ] 

Robert Joseph Evans commented on HADOOP-8305:
---------------------------------------------

Yes Cross project/hadoop-tools precommit builds will not work until HADOOP-8308 
goes in.

{noformat}
-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified test 
files.

    -1 javadoc.  The javadoc tool appears to have generated 16 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 20 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.
{noformat}

Which is the same as running with a noop patch

{noformat}
-1 overall.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 16 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 20 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

{noformat}

So +1 I'll commit your patch tomorrow.
                
> distcp over viewfs is broken
> ----------------------------
>
>                 Key: HADOOP-8305
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8305
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.23.3, 2.0.0, 3.0.0
>            Reporter: John George
>            Assignee: John George
>         Attachments: HADOOP-8305.patch, HADOOP-8305.patch
>
>
> This is similar to MAPREDUCE-4133. distcp over viewfs is broken because 
> getDefaultReplication/BlockSize are being requested with no arguments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to