steveloughran commented on code in PR #6876: URL: https://github.com/apache/hadoop/pull/6876#discussion_r1739181576
########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md: ########## @@ -153,6 +153,14 @@ Here are the full set of configuration options. </description> </property> +<property> + <name>fs.s3a.assumed.role.external.id</name> + <value /> Review Comment: yes. ########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md: ########## @@ -153,6 +153,14 @@ Here are the full set of configuration options. </description> </property> +<property> + <name>fs.s3a.assumed.role.external.id</name> + <value /> + <description> + External id for assumed role, it's an optional configuration. + </description> Review Comment: sorry, I mean't just the URL, not an http 'a' element. it'll probably break a parser if that got pasted in anywhere -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
