[ 
https://issues.apache.org/jira/browse/HADOOP-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878199#comment-17878199
 ] 

ASF GitHub Bot commented on HADOOP-19201:
-----------------------------------------

steveloughran commented on code in PR #6876:
URL: https://github.com/apache/hadoop/pull/6876#discussion_r1739181576


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md:
##########
@@ -153,6 +153,14 @@ Here are the full set of configuration options.
   </description>
 </property>
 
+<property>
+  <name>fs.s3a.assumed.role.external.id</name>
+  <value />

Review Comment:
   yes. 



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md:
##########
@@ -153,6 +153,14 @@ Here are the full set of configuration options.
   </description>
 </property>
 
+<property>
+  <name>fs.s3a.assumed.role.external.id</name>
+  <value />
+  <description>
+    External id for assumed role, it's an optional configuration.
+  </description>

Review Comment:
   sorry, I mean't just the URL, not an http 'a' element. it'll probably break 
a parser if that got pasted in anywhere





> S3A: Support external id in assume role
> ---------------------------------------
>
>                 Key: HADOOP-19201
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19201
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Smith Cruise
>            Assignee: Smith Cruise
>            Priority: Major
>              Labels: pull-request-available
>
> Extend IAM role suport with external IDs which can be set in 
> fs.s3a.assumed.role.external.id
> Support external id in AssumedRoleCredentialProvider.
>  
> https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to