[
https://issues.apache.org/jira/browse/HADOOP-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879488#comment-17879488
]
LoggingResearch commented on HADOOP-19267:
------------------------------------------
To make it clear on how to fix the issue, we upload the comparison between the
original version and the log-enhanced version in the attached file
`original-vs-log-enhanced.md`. The log-enhanced version is generated
automatically utilizing our proposed tool.
> Logging Enhancement for Shutdown Timeout Configuration in ShutdownHookManager
> -----------------------------------------------------------------------------
>
> Key: HADOOP-19267
> URL: https://issues.apache.org/jira/browse/HADOOP-19267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.3.6
> Environment: Hadoop Version: {{`3.3.6`}}
> Location:
> {{{}`hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ShutdownHookManager.java`{}}},in
> {{`getShutdownTimeout`}} method. Lines 187-189.
> Reporter: LoggingResearch
> Priority: Major
> Attachments: TestShutdownHookManager.java, original-vs-log-enhanced.md
>
>
> The issue was encountered in scenarios where Hadoop services are expected to
> shut down gracefully within a specified time frame. Misconfigured shutdown
> timeouts can lead to abrupt terminations or extended shutdown periods. The
> original code does not provide sufficient visibility into misconfigurations
> related to the shutdown timeout duration, which can result in unexpected
> behavior during service shutdowns.
>
> *Expected Behavior:*
> The system should log a warning message when the configured shutdown timeout
> is less than the minimum allowed value, and it should reset the duration to
> this minimum value. Additionally, the user should be informed to set the
> {{hadoop.service.shutdown.timeout}} configuration parameter to a valid value.
>
> *How-to-Fix:*
> Enhance the {{getShutdownTimeout}} method by adding logging statements that
> warn when the shutdown timeout is below the allowed minimum, and reset it to
> the minimum value. This logging will help users identify and correct
> misconfigurations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
