[
https://issues.apache.org/jira/browse/HADOOP-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883446#comment-17883446
]
ASF GitHub Bot commented on HADOOP-19164:
-----------------------------------------
vinayakumarb commented on code in PR #7050:
URL: https://github.com/apache/hadoop/pull/7050#discussion_r1769464746
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NameNodeAdapterMockitoUtil.java:
##########
@@ -0,0 +1,121 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hdfs.server.namenode;
+
+import java.util.concurrent.locks.ReentrantReadWriteLock;
+
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import org.mockito.stubbing.Answer;
+
+import org.apache.commons.lang3.reflect.FieldUtils;
+import org.apache.hadoop.hdfs.DFSTestUtil;
+import org.apache.hadoop.hdfs.server.blockmanagement.BlockManager;
+import org.apache.hadoop.hdfs.server.blockmanagement.BlockManagerTestUtil;
+import org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer;
+import org.apache.hadoop.test.Whitebox;
+
+import static org.mockito.Mockito.doAnswer;
+import static org.mockito.Mockito.spy;
+
+/**
+ * This is a Mockito based utility class to expose NameNode functionality for
unit tests.
+ */
+public class NameNodeAdapterMockitoUtil {
+
+ public static BlockManager spyOnBlockManager(NameNode nn) {
+ BlockManager bmSpy = spy(nn.getNamesystem().getBlockManager());
+ nn.getNamesystem().setBlockManagerForTesting(bmSpy);
+ return bmSpy;
+ }
+
+ public static ReentrantReadWriteLock spyOnFsLock(FSNamesystem fsn) {
+ ReentrantReadWriteLock spy = spy(fsn.getFsLockForTests());
+ fsn.setFsLockForTests(spy);
+ return spy;
+ }
+
+ public static FSImage spyOnFsImage(NameNode nn1) {
+ FSNamesystem fsn = nn1.getNamesystem();
+ FSImage spy = spy(fsn.getFSImage());
+ Whitebox.setInternalState(fsn, "fsImage", spy);
+ return spy;
+ }
+
+ public static JournalSet spyOnJournalSet(NameNode nn) {
+ FSEditLog editLog = nn.getFSImage().getEditLog();
+ JournalSet js = spy(editLog.getJournalSet());
+ editLog.setJournalSetForTesting(js);
+ return js;
+ }
+
+ public static FSNamesystem spyOnNamesystem(NameNode nn) {
+ FSNamesystem fsnSpy = spy(nn.getNamesystem());
+ FSNamesystem fsnOld = nn.namesystem;
+ fsnOld.writeLock();
+ fsnSpy.writeLock();
+ nn.namesystem = fsnSpy;
+ try {
+ FieldUtils.writeDeclaredField(nn.getRpcServer(), "namesystem", fsnSpy,
true);
+ FieldUtils.writeDeclaredField(
+ fsnSpy.getBlockManager(), "namesystem", fsnSpy, true);
+ FieldUtils.writeDeclaredField(
+ fsnSpy.getLeaseManager(), "fsnamesystem", fsnSpy, true);
+ FieldUtils.writeDeclaredField(
+ fsnSpy.getBlockManager().getDatanodeManager(),
+ "namesystem", fsnSpy, true);
+ FieldUtils.writeDeclaredField(
+ BlockManagerTestUtil.getHeartbeatManager(fsnSpy.getBlockManager()),
+ "namesystem", fsnSpy, true);
+ } catch (IllegalAccessException e) {
+ throw new RuntimeException("Cannot set spy FSNamesystem", e);
+ } finally {
+ fsnSpy.writeUnlock();
+ fsnOld.writeUnlock();
+ }
+ return fsnSpy;
+ }
+
+ public static FSEditLog spyOnEditLog(NameNode nn) {
+ FSEditLog spyEditLog = spy(nn.getNamesystem().getFSImage().getEditLog());
+ DFSTestUtil.setEditLogForTesting(nn.getNamesystem(), spyEditLog);
+ EditLogTailer tailer = nn.getNamesystem().getEditLogTailer();
+ if (tailer != null) {
+ tailer.setEditLog(spyEditLog);
+ }
+ return spyEditLog;
+ }
+
+ /**
Review Comment:
formatting needed
> Hadoop CLI MiniCluster is broken
> --------------------------------
>
> Key: HADOOP-19164
> URL: https://issues.apache.org/jira/browse/HADOOP-19164
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
>
> Documentation is also broken & it doesn't work either
> (https://apache.github.io/hadoop/hadoop-project-dist/hadoop-common/CLIMiniCluster.html)
> *Fails with:*
> {noformat}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/mockito/stubbing/Answer
> at
> org.apache.hadoop.hdfs.MiniDFSCluster.isNameNodeUp(MiniDFSCluster.java:2666)
> at
> org.apache.hadoop.hdfs.MiniDFSCluster.isClusterUp(MiniDFSCluster.java:2680)
> at
> org.apache.hadoop.hdfs.MiniDFSCluster.waitClusterUp(MiniDFSCluster.java:1510)
> at
> org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:989)
> at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:588)
> at
> org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:530)
> at
> org.apache.hadoop.mapreduce.MiniHadoopClusterManager.start(MiniHadoopClusterManager.java:160)
> at
> org.apache.hadoop.mapreduce.MiniHadoopClusterManager.run(MiniHadoopClusterManager.java:132)
> at
> org.apache.hadoop.mapreduce.MiniHadoopClusterManager.main(MiniHadoopClusterManager.java:320)
> Caused by: java.lang.ClassNotFoundException: org.mockito.stubbing.Answer
> at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
> ... 9 more{noformat}
> {*}Command executed:{*}
> {noformat}
> bin/mapred minicluster -format{noformat}
> *Documentation Issues:*
> {noformat}
> bin/mapred minicluster -rmport RM_PORT -jhsport JHS_PORT{noformat}
> Without -format option it doesn't work the first time telling Namenode isn't
> formatted, So, this should be corrected.
> {noformat}
> 2024-05-04 00:35:52,933 WARN namenode.FSNamesystem: Encountered exception
> loading fsimage
> java.io.IOException: NameNode is not formatted.
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:253)
> {noformat}
> This isn't required either:
> {noformat}
> NOTE: You will need protoc 2.5.0 installed.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
