cxzl25 commented on code in PR #7068:
URL: https://github.com/apache/hadoop/pull/7068#discussion_r1773324396
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java:
##########
@@ -178,7 +178,7 @@ public static class KMSTokenRenewer extends TokenRenewer {
@Override
public boolean handleKind(Text kind) {
- return kind.equals(TOKEN_KIND);
+ return kind.equals(KMSDelegationToken.TOKEN_KIND);
Review Comment:
Maybe HADOOP-19152 fixed this problem, before HADOOP-19152,
`KMSClientProvider` inherited KeyProvider`, `KeyProvider` imported
`org.bouncycastle.jce.provider.BouncyCastleProvider`, but
`hadoop-client-runtime` did not package bcprov.
My change was to avoid initializing `KMSClientProvider`.
Do we need to backport HADOOP-19152 for 3.3 and 3.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
