anujmodi2021 commented on code in PR #7061:
URL: https://github.com/apache/hadoop/pull/7061#discussion_r1773666021
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -1597,6 +1597,11 @@ KeepAliveCache getKeepAliveCache() {
return keepAliveCache;
}
+ @VisibleForTesting
+ Timer getTimer() {
Review Comment:
Let's have this package protected.
Unit test accessing this will still be able to access.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -258,9 +258,9 @@ private AbfsClient(final URL baseUrl,
throw new IOException("Exception while initializing metric credentials
" + e);
}
}
- this.timer = new Timer(
- "abfs-timer-client", true);
if (isMetricCollectionEnabled) {
+ this.timer = new Timer(
+ "abfs-timer-client", true);
Review Comment:
While we are changing this, let's also define a Constant for the Thread name
and use that here instead of hardcoded string. We can define constant in the
same file as
`public static String ABFS_TIMER_THREAD_NAME = abfs-timer-client`
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsClient.java:
##########
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.azurebfs.AbfsConfiguration;
+import org.apache.hadoop.fs.azurebfs.AbfsCountersImpl;
+import org.apache.hadoop.fs.azurebfs.oauth2.AccessTokenProvider;
+import org.apache.hadoop.fs.azurebfs.utils.Base64;
+import org.apache.hadoop.fs.azurebfs.utils.MetricFormat;
+import org.assertj.core.api.Assertions;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import java.net.URI;
+import java.net.URL;
+import java.util.Map;
+
+import static
org.apache.hadoop.fs.azurebfs.constants.ConfigurationKeys.FS_AZURE_METRIC_ACCOUNT_KEY;
+import static
org.apache.hadoop.fs.azurebfs.constants.ConfigurationKeys.FS_AZURE_METRIC_ACCOUNT_NAME;
+import static
org.apache.hadoop.fs.azurebfs.constants.ConfigurationKeys.FS_AZURE_METRIC_FORMAT;
+
+public class TestAbfsClient {
+ private static final String ACCOUNT_NAME =
"bogusAccountName.dfs.core.windows.net";
+ private static final String ACCOUNT_KEY = "testKey";
+
+ @Test
+ public void testTimerNotInitialize() throws Exception {
+ final Configuration configuration = new Configuration();
+ AbfsConfiguration abfsConfiguration = new
AbfsConfiguration(configuration, ACCOUNT_NAME);
+
+ AbfsCounters abfsCounters = Mockito.spy(new AbfsCountersImpl(new
URI("abcd")));
+ AbfsClientContext abfsClientContext = new
AbfsClientContextBuilder().withAbfsCounters(abfsCounters).build();
+
+ // Get an instance of AbfsClient.
+ AbfsClient client = new AbfsDfsClient(new URL("https://azure.com";),
+ null,
+ abfsConfiguration,
+ (AccessTokenProvider) null,
+ null,
+ abfsClientContext);
+
+ Assertions.assertThat(client.getTimer())
+ .describedAs("Timer should not be initialized")
+ .isNull();
+
+ // Check if a thread with the name "abfs-timer-client" exists
+ Assertions.assertThat(isThreadRunning("abfs-timer-client"))
Review Comment:
Use the same constant defined in ABFSClient for thread name throughout the
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
