szetszwo commented on PR #7071:
URL: https://github.com/apache/hadoop/pull/7071#issuecomment-2376895254
>
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java:172:
LOG.debug("{} metrics system started in standby mode", prefix);:
'block' child has incorrect indentation level 8, expected level should be 6.
[Indentation]
This checkstyle warning seem a false positive. The current indentation
level 8 is better than the suggest level 6. No?
Anyway, this is an existing problem but not introduced by this pr. If it is
needed, let's fix it later.
```java
switch (initMode()) {
case NORMAL:
try { start(); }
catch (MetricsConfigException e) {
// Configuration errors (e.g., typos) should not be fatal.
// We can always start the metrics system later via JMX.
LOG.warn("Metrics system not started: "+ e.getMessage());
LOG.debug("Stacktrace: ", e);
}
break;
case STANDBY:
//line 172 in this pr
LOG.debug("{} metrics system started in standby mode", prefix);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
