tomscut commented on code in PR #7053:
URL: https://github.com/apache/hadoop/pull/7053#discussion_r1770720963
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java:
##########
@@ -258,7 +258,7 @@ NamespaceInfo retrieveNamespaceInfo() throws IOException {
while (shouldRun()) {
try {
nsInfo = bpNamenode.versionRequest();
- LOG.debug(this + " received versionRequest response: " + nsInfo);
+ LOG.debug("{} received versionRequest response: {}", this, nsInfo);
Review Comment:
> HI, IMO, "if (LOG.isDebugEnabled()) {...}" is better.
Thanks for your comment. I agree with @ayushtkn and @virajjasani here.
LOG.debug already does isDebugEnabled() internally.
<img width="872" alt="image"
src="https://github.com/user-attachments/assets/ed4f9b82-8dbd-4a89-80b5-1263f982c782";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
