[ 
https://issues.apache.org/jira/browse/HADOOP-19261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885420#comment-17885420
 ] 

ASF GitHub Bot commented on HADOOP-19261:
-----------------------------------------

jojochuang commented on PR #7057:
URL: https://github.com/apache/hadoop/pull/7057#issuecomment-2379652675

   +1 
   
   This looks like a safe change to make. Thanks Sammi.
   I'm just curious I'm looking at Hadoop qbt test history and TestDomainSocket 
doesn't seem to fail in a long time.
   Could it be that it is failing on Mac but not on Linux?




> Support force close a DomainSocket for server service
> -----------------------------------------------------
>
>                 Key: HADOOP-19261
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19261
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Sammi Chen
>            Assignee: Sammi Chen
>            Priority: Major
>              Labels: pull-request-available
>
> Currently the DomainSocket#close will check the reference count to be 0 
> before it goes on to close the socket. In server service case, server calls 
> DomainSocket#listen will add 1 to the reference count. When trying to close 
> the server socket which is blocked by accept, the close call will doing 
> endless count > 0 check, which prevent the server socket to be closed. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to