steveloughran commented on PR #7079: URL: https://github.com/apache/hadoop/pull/7079#issuecomment-2402228009
+1 to cutting the validation in raw local; the way the nio reads are executed it is safe. I should note that it only surfaces with file:// ; ChecksumFS + RawLocal, with a large enough file that multiple large ranges to be supplied close to/adjac We missed this because we were only doing small files in the unit tests and testing against HDFS and S3 in the full stack tests. "our tests were too good". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
