[ 
https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887982#comment-17887982
 ] 

ASF GitHub Bot commented on HADOOP-15984:
-----------------------------------------

slfan1989 commented on code in PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#discussion_r1793735243


##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java:
##########
@@ -448,17 +443,15 @@ public List<String> getGroups(String user) throws 
IOException {
 
     @Override
     public Set<String> getGroupsSet(String user) throws IOException {
-      Set<String> result = new HashSet();
-      result.addAll(mapping.get(user));
-      return result;
+      return new HashSet<>(mapping.get(user));
     }
   }
 
   /**
    * Verify the access for /logs, /stacks, /conf, and /logLevel
    * servlets, when authentication filters are set, but authorization is not
    * enabled.
-   * @throws Exception 
+   * @throws Exception if there is an error during, an exception will be 
thrown.

Review Comment:
   I added this comment because Yetus prompts us about JavaDoc compilation 
errors. While I included this description, I should focus more on the 
surrounding code context. I will improve it.





> Update jersey from 1.19 to 2.x
> ------------------------------
>
>                 Key: HADOOP-15984
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15984
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Akira Ajisaka
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to