slfan1989 commented on code in PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#discussion_r1793735243
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java:
##########
@@ -448,17 +443,15 @@ public List<String> getGroups(String user) throws
IOException {
@Override
public Set<String> getGroupsSet(String user) throws IOException {
- Set<String> result = new HashSet();
- result.addAll(mapping.get(user));
- return result;
+ return new HashSet<>(mapping.get(user));
}
}
/**
* Verify the access for /logs, /stacks, /conf, and /logLevel
* servlets, when authentication filters are set, but authorization is not
* enabled.
- * @throws Exception
+ * @throws Exception if there is an error during, an exception will be
thrown.
Review Comment:
I added this comment because Yetus prompts us about JavaDoc compilation
errors. While I included this description, I should focus more on the
surrounding code context. I will improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
