[ 
https://issues.apache.org/jira/browse/HADOOP-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888606#comment-17888606
 ] 

ASF GitHub Bot commented on HADOOP-19307:
-----------------------------------------

hadoop-yetus commented on PR #7111:
URL: https://github.com/apache/hadoop/pull/7111#issuecomment-2407154680

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   9m 27s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 2 new or modified test files.  |
   |||| _ branch-3.3.1 Compile Tests _ |
   | -1 :x: |  mvninstall  |  34m 51s | 
[/branch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7111/1/artifact/out/branch-mvninstall-root.txt)
 |  root in branch-3.3.1 failed.  |
   | +1 :green_heart: |  compile  |   0m 29s |  |  branch-3.3.1 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 26s |  |  branch-3.3.1 passed  |
   | +1 :green_heart: |  mvnsite  |   0m 33s |  |  branch-3.3.1 passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  branch-3.3.1 passed  |
   | +1 :green_heart: |  spotbugs  |   0m 54s |  |  branch-3.3.1 passed  |
   | +1 :green_heart: |  shadedclient  |  18m  7s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 34s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 25s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 25s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 18s | 
[/results-checkstyle-hadoop-tools_hadoop-distcp.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7111/1/artifact/out/results-checkstyle-hadoop-tools_hadoop-distcp.txt)
 |  hadoop-tools/hadoop-distcp: The patch generated 17 new + 117 unchanged - 0 
fixed = 134 total (was 117)  |
   | +1 :green_heart: |  mvnsite  |   0m 28s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 18s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   0m 53s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  17m 52s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |  19m 40s |  |  hadoop-distcp in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 40s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 107m 53s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7111/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/7111 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux 4817e62d0db9 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 
19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-3.3.1 / 98a80ca9db5e45e6937f7af74b465f86ecd966ba |
   | Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7111/1/testReport/ |
   | Max. process+thread count | 576 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7111/1/console |
   | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Add option to add parent directory of source directories to target directories
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-19307
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19307
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: tools/distcp
>    Affects Versions: 3.0.0
>         Environment: hadoop 3.3.1
>            Reporter: Authur Wang
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, when we execute the Hadoop distcp  with -update -delete src1/* 
> src2/* dest command to keep the source and target directories exactly the 
> same。 When either -update or -overwrite is specified, the *contents* of the 
> source-directories are copied to target, and not the source directories 
> themselves. 
> Consider a copy from /source/first/ and /source/second/ to /target/, where 
> the source paths have the following contents:
> hdfs://nn1:8020/source/first/1
> hdfs://nn1:8020/source/first/2
> hdfs://nn1:8020/source/second/10
> hdfs://nn1:8020/source/second/20
> distcp2 -update hdfs://nn1:8020/source/first hdfs://nn1:8020/source/second 
> hdfs://nn2:8020/target
> would yield the following contents in /target:
> hdfs://nn2:8020/target/1
> hdfs://nn2:8020/target/2
> hdfs://nn2:8020/target/10
> hdfs://nn2:8020/target/20
>  
> But, sometimes, we need to preserve parent directories like this:
> hdfs://nn1:8020/target/first/1
> hdfs://nn1:8020/target/first/2
> hdfs://nn1:8020/target/second/10
> hdfs://nn1:8020/target/second/20
>  
> So, should we introduce an option -preserveParentDir to keep the parent 
> directories to be copied with -update or -overwrite ?
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to