pan3793 commented on code in PR #7085:
URL: https://github.com/apache/hadoop/pull/7085#discussion_r1797694281
##########
hadoop-project/pom.xml:
##########
@@ -2737,6 +2737,46 @@
</dependencies>
</dependencyManagement>
</profile>
+ <profile>
+ <id>jdk17</id>
+ <activation>
+ <jdk>[17,)</jdk>
+ </activation>
+ <properties>
+ <maven.compiler.release>17</maven.compiler.release>
+ <argLine>
+ --add-opens java.base/jdk.internal.ref=ALL-UNNAMED
Review Comment:
My suggestion is just
```patch
+ <profile>
+ <id>java9</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <properties>
+ <maven.compiler.release>${javac.version}</maven.compiler.release>
+ </properties>
+ </profile>
```
and it's encouraged to
> use version numbers without the "1." prefix (supported since javac 5)
https://github.com/apache/maven-apache-parent/commit/ded34a863110021191af2db5b772b665a2789394#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R101
```patch
- <javac.version>1.8</javac.version>
+ <javac.version>8</javac.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
