[ 
https://issues.apache.org/jira/browse/HADOOP-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888887#comment-17888887
 ] 

ASF GitHub Bot commented on HADOOP-19298:
-----------------------------------------

slfan1989 commented on code in PR #7085:
URL: https://github.com/apache/hadoop/pull/7085#discussion_r1797690932


##########
hadoop-project/pom.xml:
##########
@@ -2737,6 +2737,46 @@
         </dependencies>
       </dependencyManagement>
     </profile>
+    <profile>
+      <id>jdk17</id>
+      <activation>
+        <jdk>[17,)</jdk>
+      </activation>
+      <properties>
+        <maven.compiler.release>17</maven.compiler.release>
+        <argLine>
+          --add-opens java.base/jdk.internal.ref=ALL-UNNAMED

Review Comment:
   ```
      <profile>
         <id>java9</id>
         <activation>
           <jdk>[9,)</jdk>
         </activation>
         <properties>
           <maven.compiler.release>${javac.version}</maven.compiler.release>
         </properties>
       </profile>
   ```
   
   The Javadoc configuration can be removed, as it currently doesn’t cause any 
extra errors since Pan has submitted a PR to fix the Javadoc content.
   
   cc: @pan3793 @adoroszlai 





> [JDK17] Add a JDK17 profile
> ---------------------------
>
>                 Key: HADOOP-19298
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19298
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: common
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to