[
https://issues.apache.org/jira/browse/HADOOP-19243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889085#comment-17889085
]
ASF GitHub Bot commented on HADOOP-19243:
-----------------------------------------
muskan1012 commented on PR #6968:
URL: https://github.com/apache/hadoop/pull/6968#issuecomment-2409992934
> code is good, but the import ordering is all mixed up because of how the
mockito import was moved to the new one.
>
> please review and fix
>
> * position of org.apache import in static and class imports
> * blank likes between blocks
>
> fix this and we are good. (oh, and you'll remember next time: I worry a
lot about imports because they make backporting a nightmare. Save us both time
and predict what I'll complain about before submitting patches)
Sure @steveloughran, Noted it. Thank you for reviewing it!!
> Upgrade Mockito version to 4.11.0
> ---------------------------------
>
> Key: HADOOP-19243
> URL: https://issues.apache.org/jira/browse/HADOOP-19243
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Muskan Mishra
> Assignee: Muskan Mishra
> Priority: Major
> Labels: pull-request-available
>
> While Compiling test classes with JDK17, faced error related to Mockito:
> *Mockito cannot mock this class.*
> So to make it compatible with jdk17 we have to upgrade the version of
> mockito-core as well as mockito-inline.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
