mukund-thakur commented on code in PR #7104:
URL: https://github.com/apache/hadoop/pull/7104#discussion_r1798887153
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/contract/ITestAbfsFileSystemContractSeek.java:
##########
@@ -68,6 +68,9 @@ protected Configuration createConfiguration() {
protected AbstractFSContract createContract(final Configuration conf) {
conf.setInt(AZURE_READ_AHEAD_RANGE, MIN_BUFFER_SIZE);
conf.setInt(AZURE_READ_BUFFER_SIZE, MIN_BUFFER_SIZE);
+ // Disabling cache to make sure new configs are picked up.
+ conf.set("fs.abfss.impl.disable.cache", "true");
+ conf.set("fs.abfs.impl.disable.cache", "true");
Review Comment:
setBoolean
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAuthorization.java:
##########
@@ -107,10 +112,13 @@ public void testSASTokenProviderNullSASToken() throws
Exception {
final AzureBlobFileSystem fs = this.getFileSystem();
final AzureBlobFileSystem testFs = new AzureBlobFileSystem();
- Configuration testConfig = this.getConfiguration().getRawConfiguration();
- testConfig.set(ConfigurationKeys.FS_AZURE_SAS_TOKEN_PROVIDER_TYPE,
TEST_ERR_AUTHZ_CLASS);
+ Configuration testConfig = new
Configuration(this.getConfiguration().getRawConfiguration());
+ testConfig.set(FS_AZURE_SAS_TOKEN_PROVIDER_TYPE, TEST_ERR_AUTHZ_CLASS);
+ testConfig.set(MOCK_SASTOKENPROVIDER_RETURN_EMPTY_SAS_TOKEN, "true");
Review Comment:
setBoolean
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAuthorization.java:
##########
@@ -107,10 +112,13 @@ public void testSASTokenProviderNullSASToken() throws
Exception {
final AzureBlobFileSystem fs = this.getFileSystem();
final AzureBlobFileSystem testFs = new AzureBlobFileSystem();
- Configuration testConfig = this.getConfiguration().getRawConfiguration();
- testConfig.set(ConfigurationKeys.FS_AZURE_SAS_TOKEN_PROVIDER_TYPE,
TEST_ERR_AUTHZ_CLASS);
+ Configuration testConfig = new
Configuration(this.getConfiguration().getRawConfiguration());
+ testConfig.set(FS_AZURE_SAS_TOKEN_PROVIDER_TYPE, TEST_ERR_AUTHZ_CLASS);
+ testConfig.set(MOCK_SASTOKENPROVIDER_RETURN_EMPTY_SAS_TOKEN, "true");
+ // Setting IS_HNS_ENABLED to avoid the exception thrown by the HNS check.
+ testConfig.set(FS_AZURE_ACCOUNT_IS_HNS_ENABLED,
this.getIsNamespaceEnabled(fs) + "");
Review Comment:
why do we need to append "" at the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
