[
https://issues.apache.org/jira/browse/HADOOP-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889107#comment-17889107
]
ASF GitHub Bot commented on HADOOP-18960:
-----------------------------------------
mukund-thakur commented on code in PR #7104:
URL: https://github.com/apache/hadoop/pull/7104#discussion_r1798887153
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/contract/ITestAbfsFileSystemContractSeek.java:
##########
@@ -68,6 +68,9 @@ protected Configuration createConfiguration() {
protected AbstractFSContract createContract(final Configuration conf) {
conf.setInt(AZURE_READ_AHEAD_RANGE, MIN_BUFFER_SIZE);
conf.setInt(AZURE_READ_BUFFER_SIZE, MIN_BUFFER_SIZE);
+ // Disabling cache to make sure new configs are picked up.
+ conf.set("fs.abfss.impl.disable.cache", "true");
+ conf.set("fs.abfs.impl.disable.cache", "true");
Review Comment:
setBoolean
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAuthorization.java:
##########
@@ -107,10 +112,13 @@ public void testSASTokenProviderNullSASToken() throws
Exception {
final AzureBlobFileSystem fs = this.getFileSystem();
final AzureBlobFileSystem testFs = new AzureBlobFileSystem();
- Configuration testConfig = this.getConfiguration().getRawConfiguration();
- testConfig.set(ConfigurationKeys.FS_AZURE_SAS_TOKEN_PROVIDER_TYPE,
TEST_ERR_AUTHZ_CLASS);
+ Configuration testConfig = new
Configuration(this.getConfiguration().getRawConfiguration());
+ testConfig.set(FS_AZURE_SAS_TOKEN_PROVIDER_TYPE, TEST_ERR_AUTHZ_CLASS);
+ testConfig.set(MOCK_SASTOKENPROVIDER_RETURN_EMPTY_SAS_TOKEN, "true");
Review Comment:
setBoolean
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAuthorization.java:
##########
@@ -107,10 +112,13 @@ public void testSASTokenProviderNullSASToken() throws
Exception {
final AzureBlobFileSystem fs = this.getFileSystem();
final AzureBlobFileSystem testFs = new AzureBlobFileSystem();
- Configuration testConfig = this.getConfiguration().getRawConfiguration();
- testConfig.set(ConfigurationKeys.FS_AZURE_SAS_TOKEN_PROVIDER_TYPE,
TEST_ERR_AUTHZ_CLASS);
+ Configuration testConfig = new
Configuration(this.getConfiguration().getRawConfiguration());
+ testConfig.set(FS_AZURE_SAS_TOKEN_PROVIDER_TYPE, TEST_ERR_AUTHZ_CLASS);
+ testConfig.set(MOCK_SASTOKENPROVIDER_RETURN_EMPTY_SAS_TOKEN, "true");
+ // Setting IS_HNS_ENABLED to avoid the exception thrown by the HNS check.
+ testConfig.set(FS_AZURE_ACCOUNT_IS_HNS_ENABLED,
this.getIsNamespaceEnabled(fs) + "");
Review Comment:
why do we need to append "" at the end?
> ABFS contract-tests with Hadoop-Commons intermittently failing
> --------------------------------------------------------------
>
> Key: HADOOP-18960
> URL: https://issues.apache.org/jira/browse/HADOOP-18960
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Reporter: Pranav Saxena
> Assignee: Anuj Modi
> Priority: Minor
> Labels: pull-request-available
>
> In the merged pr [HADOOP-18869: [ABFS] Fixing Behavior of a File System APIs
> on root path by anujmodi2021 · Pull Request #6003 · apache/hadoop
> (github.com)|https://github.com/apache/hadoop/pull/6003], a config was
> switched-on: `fs.contract.test.root-tests-enabled`. This enables the root
> manipulation tests for the filesystem contract.
> Now, the execution of contract-tests in abfs works as per executionId
> integration-test-abfs-parallel-classes of the pom. The tests would work in
> different jvms, and at a given instance multiple such jvms could be there,
> depending on ${testsThreadCount}. The problem is that all the test jvms for
> contract-test use the same container for test runs which is defined by
> `fs.contract.test.fs.abfs`. Due to this, one jvm root-contract-runs can
> influence other jvm's root-contract-runs. This leads to CI failures for
> hadoop-azure package.
> Solution is to run these tests sequentially and separate from other
> commit/manifest tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
